-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove AC #8979
Remove AC #8979
Conversation
I'll update the warning count (it goes down) once I have a LibCI run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need a dedicated unit-test of cross version testing - exe compiled with 2.4[1-5] that invokes the deprecated calls with dll compiled with v.2.46+
wrappers/android/librealsense/src/main/java/com/intel/realsense/librealsense/Option.java
Outdated
Show resolved
Hide resolved
Not a bad idea |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tough call...
approved.
* java, matlab, node.js, pybackend, unreal * remove rs2_cah_trigger
Backwards-compatibility is maintained at the level of the C runtime, but not the wrappers or C/C++ compilations:
rs2_cah_trigger
, for example, was removed -- code using it will not compile.Likewise, the options for TRIGGER and RESET are still there, but nothing supports them and so they have been removed from most wrappers.
Interfaces like
calibrated_sensor
are still there, but no longer in use.