Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove AC #8979

Merged
merged 10 commits into from
May 10, 2021
Merged

Remove AC #8979

merged 10 commits into from
May 10, 2021

Conversation

maloel
Copy link
Collaborator

@maloel maloel commented May 6, 2021

Backwards-compatibility is maintained at the level of the C runtime, but not the wrappers or C/C++ compilations:
rs2_cah_trigger, for example, was removed -- code using it will not compile.
Likewise, the options for TRIGGER and RESET are still there, but nothing supports them and so they have been removed from most wrappers.

Interfaces like calibrated_sensor are still there, but no longer in use.

@maloel
Copy link
Collaborator Author

maloel commented May 6, 2021

I'll update the warning count (it goes down) once I have a LibCI run

@maloel maloel requested a review from ev-mp May 6, 2021 14:30
Copy link
Collaborator

@ev-mp ev-mp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need a dedicated unit-test of cross version testing - exe compiled with 2.4[1-5] that invokes the deprecated calls with dll compiled with v.2.46+

include/librealsense2/h/rs_option.h Outdated Show resolved Hide resolved
include/librealsense2/h/rs_option.h Show resolved Hide resolved
src/rs.cpp Outdated Show resolved Hide resolved
include/librealsense2/h/rs_option.h Show resolved Hide resolved
wrappers/matlab/option.m Outdated Show resolved Hide resolved
@maloel
Copy link
Collaborator Author

maloel commented May 9, 2021

I think we need a dedicated unit-test of cross version testing - exe compiled with 2.4[1-5] that invokes the deprecated calls with dll compiled with v.2.46+

Not a bad idea

Copy link
Collaborator

@ev-mp ev-mp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tough call...
approved.

@maloel maloel merged commit 9924d46 into IntelRealSense:development May 10, 2021
@maloel maloel deleted the noac branch August 17, 2021 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants