Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ucal fixes #9882

Merged
merged 8 commits into from
Oct 24, 2021
Merged

Ucal fixes #9882

merged 8 commits into from
Oct 24, 2021

Conversation

ev-mp
Copy link
Collaborator

@ev-mp ev-mp commented Oct 21, 2021

Ucal amendments
Tracked on: DSO-17774, DSO-17775, LRS-323

Change-Id: If097075eaca121384c1402fb5472463b6802f6d5
… enhancements.

LRS-323

Change-Id: I779cf59b0a7866a91eb1339cd67a22b821da1815
Change-Id: I21926ff7abf4b5c84a115b9b3d36083a17001361
Change-Id: I93a771edfe5f7b98e022104916ac45bdeea67e6f
Change-Id: Ie63198250ade72738baa9ba34f2865b5fc72e643
Change-Id: I99d3bb2b09b72888d28ba35b0fc6f0a462337c46
Change-Id: Ieb960bb265a02af3a354c33c9234cc52ef212c78
@ev-mp ev-mp requested a review from remibettan October 21, 2021 09:02
Change-Id: I64a437f46c91095352fe71f827e6b4f7018626f2
Copy link
Contributor

@remibettan remibettan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comment - relevant for several files

@@ -1012,6 +1012,8 @@ namespace rs2
float step = 50.f / limit; // frames gathering is 50% of the process, the rest is the internal data extraction and algo processing

rs2::frame_queue queue(limit*2,true);
rs2::frame_queue queue2(limit * 2, true);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you think of some other name than queue, queue2 and queu3, so that it would explain the aim of it?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those are marked opaque on purpose to allow incremental development

@remibettan
Copy link
Contributor

Approved

@ev-mp ev-mp merged commit 8aa7473 into IntelRealSense:development Oct 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants