-
-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Undo of big pastes does not remove all blocks #1861
Comments
Is this just a visual bug, or are the blocks still present after a rejoin? |
They are still present after a rejoin |
What was the amount of blocks you did this with? With 150 billion blocks I had no issue, it just takes a few secs longer to send all the data to the client |
I tried with ~3 millions. I can reproduce it really easily so it maybe comes from another plugin ? |
Please send the schematic here in GitHub. There should be a button at the bottom of this text box where you type the comment that says "Attach files by dragging & dropping, selecting or pasting them." If you are unable to find this button, then you can drag and drop the file onto this comment text box. This doesn't feel like the sort of issue that would be caused by particular blocks (I would expect errors being thrown in the console instead of silence), but it's very worth trying out the schematic. |
undoBug.zip |
Ah. That makes sense. Many thanks for sending the schematic file. I am looking into it. |
So i just re-tried with only a few plugins ( FAWE, Multiverse-Core and PlotSquared ) and the bug is not showing at the first //undo. |
I'm experiencing a similar issue, but with a relatively small paste (a gateway for a castle, maybe a thousand or so blocks tops) |
Same has been happening here throughout several months by now, just thought I'd add my experience to this issue at least :) It's just happened yesterday for a user with a massive schematic (like 300 million blocks) where after using "//undo" small fragments where left over seemingly at random. |
I'm able to replicate the issue using that schematic multiple times |
It doesn't happen when you do //paste without -e and then //undo. It always happens when you //paste -e and //undo (sometimes need to be done twice in a row) on these schematics, I guess it is an issue with entities, some TileEntities break as seen in my debugpaste here. Debugpaste with log and stacktrace: |
- Completely nullifies issue of writing to SET between processing submission and processing completion - Leads to larger memory footprint, but that is acceptable - Leads to performance improvement in processing as there is no need to perform any multi-threading protection operations - Fixes #1861 - Fixes #2074 (gonna go ahead and say it does, this is really the only thing I can think of to do with the issue, and it's super rare anyway (never replicated by anyone else))
Server Implementation
Paper
Server Version
1.18.2
Describe the bug
The //undo for big structures does not seem to remove all the blocks pasted.
To Reproduce
Expected behaviour
Clear all the blocks pasted.
Screenshots / Videos
https://www.youtube.com/watch?v=POocbUssI9s
Error log (if applicable)
No response
Fawe Debugpaste
https://athion.net/ISPaster/paste/view/1245dfd6feb14454a9f6596869f929f3
Fawe Version
FastAsyncWorldEdit version 2.4.1-SNAPSHOT-237;dbfb521
Checklist
Anything else?
Actually my build isn't the newest but the last two were updates of paperweight and some docs modifications as far as i see.
The text was updated successfully, but these errors were encountered: