Add dotnet tool ability to XMLtoMD proj #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
BenjaminMichaelis
commented
Mar 6, 2021
BenjaminMichaelis
commented
- DragonFruit CLI tool added
- pack and nupkg tool ability added
- upgraded from .netcore3.1 to .net5.0 - suppressed warning syslib0012 Will need to address https://docs.microsoft.com/en-us/dotnet/core/compatibility/syslib-warnings/syslib0012 Most likely by using Assembly.Location
- added XML nodes for ability to pack and distribute the application as a nupkg
.Net 5.0 upgrade will be coming in the future
Keboo
reviewed
Mar 10, 2021
XMLtoMD/GuidelineXmlToMD/Program.cs
Outdated
| /// <param name="i">The xml file to process when using the -m option</param> | ||
| /// <param name="o">The md file to create when using the -m option </param> | ||
| /// <param name="m">Manual Run - Use xmlFilePath and outputMDFilePath</param> | ||
| static void Main(string[] args, string xmlFileName, string i = "null", string o = "null", bool m = false) |
There was a problem hiding this comment.
You shouldn't need to take in the string args and instead just specify the parameters that you need.
This will likely require changing the invocation on the GitHub Action.
You can use FileInfo as the parameter type and it will properly parse it for you.
Suggested change
| static void Main(string[] args, string xmlFileName, string i = "null", string o = "null", bool m = false) | |
| static void Main(string xmlFileName, string i = "null", string o = "null", bool m = false) |
There was a problem hiding this comment.
Removed default args []
Co-authored-by: Kevin B <Keboo@users.noreply.github.com>
|
What's the status on this? @Keboo |
Keboo
approved these changes
Apr 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.