-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
God's name localized in the "Donation" dialog #2550
God's name localized in the "Donation" dialog #2550
Conversation
{ | ||
string god = Temple.GetDivine(factionId).ToString(); | ||
if (!string.IsNullOrEmpty(god)) | ||
return TextManager.Instance.GetLocalizedText(god); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this use the factionId as key and the Factions collection? I'm not sure about how this works, but I don't think there are entries named after the gods
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically I could call GetLocalizedText in DaggerfallGuildServiceDonation.cs
Will it be a better solution?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gonna let @Interkarma judge on this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My mental map is a bit fuzzy here, but I can quickly confirm the following keys are present in the string tables.
Akatosh
Arkay
Dibella
Julianos
Kynareth
Mara
Stendarr
Zenithar
If the faction ID to string is guaranteed to always return one of those keys (case sensitive) in this process, then it's at least on the right track. I'd have to step through this one to be sure of the outcome however. Daggerfall being Daggerfall, there always seems to be some edge case I don't expect. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, in this exact dialog we have a Macro Context, that overrides the %god macro, and the text is not translated.
Assets/Scripts/Game/UserInterfaceWindows/DaggerfallGuildServiceDonation.cs
Outdated
Show resolved
Hide resolved
Code review fixes
God's name localized in the "Donation" dialog