Golden tests for the non-integral calculations #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaredCorduan
reviewed
May 6, 2019
| ] | ||
| ] | ||
| print $ map leaderComputation leaderTest | ||
| -- precomputedLeader <- |
There was a problem hiding this comment.
any reason to keep all these comments in?
There was a problem hiding this comment.
thanks for catching this, I removed all those comments and also unused definitions
The C++ test program emits test results to stdout and benchmark timing to stderr.
- Remove commented out code - Remove unused definitions from older versions
mgudemann
force-pushed
the
reference/golden_tests
branch
from
63272a4
to
62a71f2
Compare
kevinhammond
pushed a commit
that referenced
this pull request
Oct 28, 2019
Golden tests for the non-integral calculations
nc6
pushed a commit
that referenced
this pull request
May 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds golden tests in the following format
x a band checks for
e^x ln(a) (1-(1-f)^b) (approx(a < 1-(1-f)^b)) LT/GT nwere the last uses Taylor series expansion to approximate the threshold calculation and uses the error term to expand only as far as necessary.