You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Following a phone discussion and a user bug report
The current algorithm for adding Wikipedia POIs to IHM has a few issues:
It may drop Wikipedia pages that should be shown or merged with OSM POIs.
It may show Wikipedia pages that do not have a location.
It is not scalable
This issue proposes to reverse the search direction. Rather than searching Wikipedia for pages that exists within a given bounding box, the new approach would identify the relevant Wikipedia pages based on OSM tags.
The down-side for such a change is that the IHM POI layer will no longer show Wikipedia pages that do not have an OSM element.
The identification could use the the wikipedia, wikipedia:he, and wikipedia:en tags, as used in the POI merge algorithm, or it can rely solely on wikidata tags, similar to openmaptiles.
Note: The current search-and-match algorithm could be used for periodic bulk OSM edits that will add the missing tag/s.
What steps will reproduce the bug?
The POI layer does not include a Wikipedia POI for זיתן, and the OSM-based POI for זיתן does not have a Wikipedia link
Hebrew Wikipedia has a page for זיתן with a location.
There is also an opposite case where a Wikipedia page that does not have a location is shown as a IHM POI
The Wikipedia page בית הכנסת צלאת בן שאיף does not have a location, it is not returned by the Wikipedia API, but it exists as an IHM POI.
What I expect to happen
Use OSM tags to identify Wikipedia pages
Platform
Israel Hiking Map app
Israel Hiking Map site in a browser
OS Name and Version
All
Browser Name and Version
All
Additional information
These problems with the contents of the Wikipedia POI layer, may also be related to #1971.
The text was updated successfully, but these errors were encountered:
Note that many Wikipedia POIs are not exactly at the right coordinates. This is natural for an encyclopedia that is mostly text based and less about exact geo like osm. When merging, my recommendation is to rely on OSM for location.
What happened?
Following a phone discussion and a user bug report
The current algorithm for adding Wikipedia POIs to IHM has a few issues:
This issue proposes to reverse the search direction. Rather than searching Wikipedia for pages that exists within a given bounding box, the new approach would identify the relevant Wikipedia pages based on OSM tags.
The down-side for such a change is that the IHM POI layer will no longer show Wikipedia pages that do not have an OSM element.
The identification could use the the
wikipedia
,wikipedia:he
, andwikipedia:en
tags, as used in the POI merge algorithm, or it can rely solely onwikidata
tags, similar to openmaptiles.Note: The current search-and-match algorithm could be used for periodic bulk OSM edits that will add the missing tag/s.
What steps will reproduce the bug?
The POI layer does not include a Wikipedia POI for זיתן, and the OSM-based POI for זיתן does not have a Wikipedia link
Hebrew Wikipedia has a page for זיתן with a location.
The Hebrew Wikipedia API returns that page
There is also an opposite case where a Wikipedia page that does not have a location is shown as a IHM POI
The Wikipedia page בית הכנסת צלאת בן שאיף does not have a location, it is not returned by the Wikipedia API, but it exists as an IHM POI.
What I expect to happen
Use OSM tags to identify Wikipedia pages
Platform
OS Name and Version
All
Browser Name and Version
All
Additional information
These problems with the contents of the Wikipedia POI layer, may also be related to #1971.
The text was updated successfully, but these errors were encountered: