Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In case of a lot of traces the UI hangs for a bit #1980

Open
zstadler opened this issue Mar 24, 2024 · 8 comments
Open

In case of a lot of traces the UI hangs for a bit #1980

zstadler opened this issue Mar 24, 2024 · 8 comments
Assignees
Labels
bug Low Nice to have or feature or a very edge case bug

Comments

@zstadler
Copy link
Member

What is the problem this feature will solve?

It takes more than 10 second for the "My Recordings" list to be ready., i.e., the spinner stops.

What is the feature you are proposing to solve the problem?

Allow the client to cache the pictures it receives from the server

What alternatives have you considered or tried?

None

Additional information

image

@HarelM
Copy link
Member

HarelM commented Mar 25, 2024

The browser should cache those, shouldn't it?

@zstadler
Copy link
Member Author

It does not look like it uses the cache.

@HarelM
Copy link
Member

HarelM commented Mar 26, 2024

Might be some missing cache control headers...

@zstadler
Copy link
Member Author

Indeed. I'm reading about the Cache-Control header and the underlying mechanism.

Stay tuned...

@zstadler
Copy link
Member Author

Now that caching is enabled, the opening still takes a long time.

There seem to be two consecutive "batches" of thumbnail requests delayed by about 9 seconds. Until the second batch is completed, the track list does not respond to the user. The images requested of the first and second batches are identical

image

@HarelM
Copy link
Member

HarelM commented Mar 31, 2024

I'll add those in the backend API definition, it won't be configurable, but it shouldn't change much.
I've set it to 10 hrs for cloud saves and 1 year for recordings.
I also added angular tracking of the elements in the dialog to avoid multiple rendering of images and to cause more network calls.

If you think there should be other numbers let me know before I commit and close this issue.

@HarelM HarelM self-assigned this Mar 31, 2024
@HarelM HarelM added the Low Nice to have or feature or a very edge case bug label Mar 31, 2024
@HarelM HarelM added this to the Next Release milestone Mar 31, 2024
@HarelM HarelM modified the milestones: Version 9.20.2, Next Release Apr 2, 2024
HarelM added a commit that referenced this issue Apr 4, 2024
@HarelM HarelM changed the title Allow caching of recording thumbnails In case of a lot of traces the UI hands for a bit Apr 4, 2024
@HarelM HarelM added bug and removed enhancement labels Apr 4, 2024
@HarelM
Copy link
Member

HarelM commented Apr 4, 2024

I've added cache control, but the problem is in the UI when syncing the traces.

HarelM added a commit that referenced this issue Apr 4, 2024
@HarelM
Copy link
Member

HarelM commented Apr 4, 2024

Testing this locally shows good improvement, but I think my machine runs faster.
I'll deploy this once the docker is ready so you can test if the performance improvements are enough.

@zstadler zstadler changed the title In case of a lot of traces the UI hands for a bit In case of a lot of traces the UI hangs for a bit Apr 4, 2024
@HarelM HarelM modified the milestones: Version 9.20.40, Next Release May 22, 2024
@HarelM HarelM removed this from the Version 9.20.158 milestone Aug 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Low Nice to have or feature or a very edge case bug
Projects
None yet
Development

No branches or pull requests

2 participants