Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "business tasks" to "tasks and behaviours" #1256

Closed
samm82 opened this issue May 3, 2019 · 8 comments
Closed

Change "business tasks" to "tasks and behaviours" #1256

samm82 opened this issue May 3, 2019 · 8 comments
Assignees

Comments

@samm82
Copy link
Collaborator

samm82 commented May 3, 2019

Noted in 75f2b88, the phrase "business tasks" in the requirements intro "jumps off the page... in a scientific context" and should be replaced with "tasks and behaviours".

@smiths
Copy link
Collaborator

smiths commented May 3, 2019

@samm82, I would think the text that defines functional requirements wouldn't be reproduced in each case study. Hopefully it is something we can change in one place and change it for all examples. If that is not the case, we should think about changing our overall design.

@samm82
Copy link
Collaborator Author

samm82 commented May 3, 2019

When adding this function requirements intro (maybe I should have thought about this a little more) I copied and pasted it from overarching requirements intro, and removed what wasn't relevant, which ended up matching caseStudies. It would have to be changed at least in these two locations/generalized so that it doesn't have to be.

@smiths
Copy link
Collaborator

smiths commented May 3, 2019

@samm82, any time you find yourself using copy and paste in Drasil, we should be looking for an opportunity for abstraction. 😄

I'm not sure of the current status here. Can this definition of functional requirements be written so that all of the cases studies are the same? Is it possible to have the text written in one place and pulled into all of the examples? If the text changes in the future, we would like to only have to change it in one place. The definition of functional requirements should be knowledge that Drasil knows, although I don't think we have yet spent much time "teaching" it about software engineering concepts.

@samm82
Copy link
Collaborator Author

samm82 commented May 3, 2019

I thought of that as soon as I typed "copy and paste". 😬 I'll take a look into it later. 👌

@samm82
Copy link
Collaborator Author

samm82 commented May 6, 2019

@smiths When I updated the functional requirements intro, it was done in drasil-docLang, so this change propagated to all examples. The nonfunctional requirements sections across all examples are small enough that they don't have (or need) an intro. The way to generalize this I think would be to create the requirements intro from the functional and nonfunctional requirements intros, but since the nonfunctional requirements intro doesn't have one, this would be... interesting. Should I start by just building the requirements intro from the functional one and then adding the text from the nonfunctional (ie. reqIntro = funcIntro + S "other info from nonFuncIntro"), or should I created a nonfunctional intro for the future that will be unused for now? (Although, based on the conversation about glassConcepts in #1254, I think this is undesirable.)

Also, there is a difference between "This section..." from the reqIntro and "The following section..." from the funcIntro - which one is preferred?

@bmaclach
Copy link
Collaborator

bmaclach commented May 6, 2019

Going to call out #1229 because I think it's relevant here. I changed the DocLang to format NFRs similarly to functional requirements (i.e. an intro sentence followed by a list of requirements). It just hasn't been propagated to the examples yet.

@samm82
Copy link
Collaborator Author

samm82 commented May 6, 2019

Good call - I completely forgot about that issue 😂 I'm going to close this issue, since it seems like a subset of #1229, and I'll work on the implementation over there.

@samm82 samm82 closed this as completed May 6, 2019
@smiths
Copy link
Collaborator

smiths commented May 6, 2019

I was going to search for the issue that @bmaclach mentioned as being related. I'm glad that he beat me to it. 😄

JacquesCarette pushed a commit that referenced this issue May 6, 2019
* Changed 'business tasks' to 'tasks and behaviours' as per #1256

* Added infrastructure for NFR intro

* Added more infrastructure for converting NFR style to FR style

* Added first testing NFR a la previous FR structure for SSP

* Removed accidental table duplication

* Merged test NFR with Brooks's change - will re-add introduction

* Req Intro now displaying and transistioned to nfReqF

* Added Reusability and Maintainability requirements to SSP

* Added Correct NFR to SSP

* Changed implementation of nonFunqReq' to take an int and fix processing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants