FReqsSub Should take [ConceptInstance]?

[samm82]

Related to #1023, as well as #1229 and its bunny trail of related issues. (Not sure if there is already an issue specifically for this, but I couldn't find one.)

I was about to implement the Requirements for Projectile, but realized that it would probably make more sense to revise this code before adding another example that will break it.

Drasil/code/drasil-docLang/Drasil/DocumentLanguage.hs

Lines 197 to 199 in 8d0bbbe

	data ReqsSub where
	FReqsSub :: [Contents] -> ReqsSub --FIXME: Should be ReqChunks?
	NonFReqsSub :: [ConceptInstance] -> ReqsSub

Since NonFReqsSub was refactored to take a [ConceptInstance], it makes sense that FReqsSub should be as well.

I don't want to step on anyone's toes, so @bmaclach, @Mornix, @JacquesCarette, @smiths, and/or anyone else feel free to let me know if this issue should be reassigned, pushed to later, or tackled now.

TODO

• GamePhysics
• GlassBR
• NoPCM
• SSP
• SWHS
• Replace FReqsSub with FReqsSub'

Closed with merge of #1461

[smiths]

@samm82, your proposal makes sense to me, under the assumption that fixing FReqsSub will not take much time. We don't want to introduce code that we know will eventually need to be changed, but we also don't want to get distracted from advancing on our complete projectile example. 😄

[samm82]

I'll put this on the back burner for now 😉

[samm82]

@smiths Would it be an acceptable compromise for me to create a new FReqsSub' that takes a ConceptInstance for adding the requirements to Projectile, then I (or someone else) can come back to this issue and finish the job in the other examples?

[smiths]

@samm82 that sounds reasonable to me.

[samm82]

A note - FReqsSub' should be modified to also take a [LabelledContent] for the tables.