-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to Tables Instead of Lists in GlassBR Func Reqs #1460
Comments
I'm not sure what you are asking @samm82. When you say labelled list, do you mean a table with a header row at the top? If you are asking whether the requirements can include tables, I see no problem with that. If you are asking something else, I don't know what my opinion is. :-) |
Yeah, sorry I meant tables. (my bad) The one potential issue I could see with that is that the tables would be "separated" from the original requirement, as generating them automatically requires passing in the requirements and tables separately, but since it's already being utilized, I think we should be OK. 👍 |
What is "already being utilized"? Do you mean that the table and the requirement are separated in the Drasil code, or in the generated documentation? |
In the above screenshot, the table peeking out from the bottom is the |
I'm still not sure I know what you are asking. If you are suggesting we combine the lists from separate requirements into one table, I don't like that idea at all. We want a separation of concerns. If there is a table that lists the inputs, we don't want to confuse things by including non-inputs in the same table. |
No, there would be three separate tables, with the following layout and working references:
|
Hopefully I fully understand what you are proposing, but assuming I do, I like it. The table would actually include the key information; that is, they would contain the information of most interest to the code generator. |
I think he is in part asking about removing the list, because right now there is a weakness in Drasil that doesn't support them in that specific context. Now, it may well be that the information can be re-arranged in a different format that would, in this case, be better. But as a general rule, we shouldn't try too hard to change formatting just because of a weakness in Drasil. |
Already changed in #1461 |
The fact that these FRs are represented as lists presents issues for #1403. Would it be acceptable to represent them as labelled
liststables instead, with columns Symbol, Description, Source, and Units?The text was updated successfully, but these errors were encountered: