-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Website - Different links for different file types #1596
Comments
@Mornix I'm trying to figure out what's exactly going on here, especially what happens right after |
The Let me know if anything is unclear or doesn’t make sense. |
Still not entirely sure about how exactly the monads are manipulating things. But, after staring at the screen for a while, I actually found a MUCH easier fix in the Updated in: 0588ab3 |
Minor thing - can you not center the |
@Mornix could you help explain line 72 here. I'm thinking of having the file list the different subfolders under Drasil/code/scripts/deploy_stage.sh Lines 58 to 75 in 47c3358
|
@JacquesCarette for sure! That will be tracked updated and tracked via #1597. |
Line 72 calls the A likely good option is to store the result of the |
You should be able to achieve exactly the same output by replacing Which has the added benefit of avoiding location side-effects and hardcoded information. |
I have tried these but none work.
|
Looking at what I wrote, is the line I suggested just printing the languages and not the prefix path? If so, I think some |
They all fail as a directory is not found. The first suggestion tries to get into the ...../code/code /.... folder which doesn't exist. Weird. |
Right.
|
The rev-parse I just posted will definitely require some fixup with |
Worked out the command line: ls -d "$(git rev-parse --show-toplevel)/$(make deploy_code_path | grep "glassbr" | cut -d: -f2-)"*/ | rev | cut -d/ -f2 | rev | tr '\n' '\0' | xargs -0 printf "$(make deploy_code_path | grep "glassbr" | cut -d: -f2-)%s\n" (Which you can run directly to verify the output is as expected.) Where it could be abstracted to and placed in the script as: REL_PATH=$(cd "$CUR_DIR" && "$MAKE" deploy_code_path | grep "$example_name" | cut -d"$DEPLOY_CODE_PATH_KV_SEP" -f 2-)
ls -d "$(git rev-parse --show-toplevel)/$REL_PATH"*/ | rev | cut -d/ -f2 | rev | tr '\n' '\0' | xargs -0 printf "$REL_PATH%s\n" > "$EXAMPLE_DEST$example_name/src" |
As of d77b0ec I have added different links for each generated language. The only problem now is that the "Generated Code" heading appears for each example. I think this is due to the Two possible solutions I can think of right now:
Not sure which would be more desired. Or maybe there is another solution I cannot think of. |
@JacquesCarette may feel otherwise, but the empty generated code links don't bother me. Eventually we will fill them in. This gives us a reminder that we haven't done this yet. It doesn't seem like something that we should stress over. |
"Generated Code" section removed if no example does not have source code via db5ff51 Once this has been merged in, the issue can be closed. |
As per @JacquesCarette's comments in #1527.
The text was updated successfully, but these errors were encountered: