PR - Webpage Updating (Intro, generated code headings, Documentation, icon) #1653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mornix
reviewed
Jul 6, 2019
Mornix
reviewed
Jul 6, 2019
Mornix
reviewed
Jul 6, 2019
Mornix
reviewed
Jul 6, 2019
Mornix
reviewed
Jul 6, 2019
Mornix
reviewed
Jul 6, 2019
code/website/index.html
Outdated
| <h3 id="haskDoc">Haskell Documentation</h3> | ||
| <p> | ||
| The current documentation for the Drasil framework can be found at | ||
| <a href="$docsUrl$">this link</a>. |
There was a problem hiding this comment.
Suggestion: I'm not a fan of "this link" (even though I'm occasionally guilty of doing it); maybe something like "The (link)Haddock Documentation(/link) for the Drasil framework." @JacquesCarette or @smiths may have other suggestion or preferences though.
There was a problem hiding this comment.
I agree with @Mornix. "this link" doesn't tell you what it is if you just scan the links. I like the Haddock Documentation suggestion.
There was a problem hiding this comment.
Currently I have:
The current <a href="$docsUrl$">Haddock documentation</a> for the Drasil framework.
There was a problem hiding this comment.
Good - I completely agree that "this link" style is bad.
Mornix
reviewed
Jul 6, 2019
Mornix
reviewed
Jul 6, 2019
JacquesCarette
requested changes
Jul 10, 2019
… to Documentation.
JacquesCarette
approved these changes
Jul 10, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the current website with a few additions.
I believe this can close the following issues: #1596, #1597, #1599, and #1633.
We can always reopen or create a new issue if something should be changed.