Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Fix #1692

Merged
merged 2 commits into from
Jul 12, 2019
Merged

Deploy Fix #1692

merged 2 commits into from
Jul 12, 2019

Conversation

Mornix
Copy link
Collaborator

@Mornix Mornix commented Jul 10, 2019

This is a small PR relating to a bad way to capture path information I suggested in #1653. The path I suggested works in a staged deploy, but a real deploy has the deploy folder as a git repo which is what rev-parse picks up. This corrects that oversight.

This PR addresses the build failure of master which only failed due to the deploy failure and not a code failure. Subsequent commits to master will pass regardless of other (passing) merges, however deploys will fail until this PR is merged.

@JacquesCarette JacquesCarette merged commit bcbe2db into master Jul 12, 2019
@JacquesCarette JacquesCarette deleted the deploy_fix branch July 12, 2019 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants