-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Product Use Case Table Number in GlassBR SRS #833
Comments
Yes, please update the generated tex so that the table number is correct. However, I have a feeling that this might be challenging. It doesn't happen often, but I vaguely recall running into issues like this in the past. It may be a weird interaction between LaTeX packages. It might not be easy to diagnose the problem and come up with a fix. |
The correct table number is shown when the Table of Symbols (the only |
Any recommendation on how to fix this? |
We could make every table referable (ie. give them captions with their numbers), although this could have formatting issues for the LaTeX. This would also allow us to reference these tables directly in the future. |
I think that yes, all tables should be referable. We should label all tables, but may indeed choose to have an empty caption (which should help with the formatting). |
An update: out of the three tables that appear before this "Table 2" (Table of Units, Table of Symbols, and Abbreviations and Acronyms), "Table 1" is the only one that uses Thoughts? EDIT: Once I fix this, should I make a low priority issue to add an option for foregoing the caption? I think this will be a little difficult, since you can't prevent |
@samm82, your recommendation seems to match with the comment from @JacquesCarette from last summer. You can create a table with a caption, and set the caption to an empty string. |
I interpreted Dr. Carette's comment to have an "empty caption" to mean that there shouldn't be anything under the table, but I think an "empty caption" as in no description is straightforward enough. My one suspicion is that an empty string will cause "Table #:" to be displayed under the table, and the colon would be unwanted, but I'll check it out tomorrow. |
@samm82, you have a good point about the Table number. I think what we are talking about is the same interface in Drasil, but having an empty caption in Drasil. I'm sure @JacquesCarette will let us know what he is thinking. 😄 |
This comment has been minimized.
This comment has been minimized.
The behaviour is changed so that every table is numbered (and labelled ie. "Table 1" in LaTeX) and the caption can be toggled ("Table 1" vs. "Table 1: Table of Units"). Will be closed with merge of #1250. |
My opinion: good work @samm82 ! |
* Added Functional Requirements intro to all examples * Updated cabal files from previous commit * Removed deprecated note from FR1 in GlassBR; closes #877 * Bumped drasil-data version number * SSP Functional Requirements (#1230) * Updated requirements 1-3 * Removed the unnecessary/bad requirements * Updated R4-R6 * Updated R7-R8 * Updated R9-R11 * Added table of inputs to output * Fixed errors and warnings * Added caption to new table * Updated stable * Added requirement about writing output to file * Updated stable * SSP Referable Goals (#1232) * Updated stable - LCs in traceability matrix * Added goalStmtDom so that goal statements can be made CIs * Made referable concept instances out of the SSP goals * Cleaned warnings and updated stable * SSP Cleanup (#1234) * Added missing citations of Karchewski paper, updated stable (LC traceability) * Removed rigid finite element def * Changed last use of SSA acronym to SSP * Added ssp to acronym table, removed ssa * Updated confusing description * Signed my name * updated stable * Fixed warning causing failed build * Updated stable * Add build target to drasil-code generated Makefiles (#1239) * Make Make build generator more abstract. * Add support for Phony targets to make printer. * Create smart constructors for Rules and Commands. * Add build AST to drasil-code for generating Makefiles. * Make file generation (for codegen) more flexible. * Use drasil-build in drasil-code to expose a renderer for build scripts. * Enable makefile generation for drasil-code codegen. (Only 'run' target at the moment) * Rename RunName to BuildName and cleanup AST. * Add infrastructure for a language's BuildConfig. * Add buildConfig field to language Configs. * Enable build target for code Makefiles. * Generate build target even if the language requires no building to have a consistent make target when invoked with no arguments. * Fixed list concatenation in Requirements.hs * Improved caption generated for tables; as per #833
This table is called "Table 2", despite being the first table in the document. It should be updated to "Table 1" to match caseStudies and be correct.
The rest of the tables then need to be shifted ie. the following should be tables 2 and 3:
The text was updated successfully, but these errors were encountered: