Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Product Use Case Table Number in GlassBR SRS #833

Closed
samm82 opened this issue Jul 11, 2018 · 12 comments · Fixed by #1250
Closed

Product Use Case Table Number in GlassBR SRS #833

samm82 opened this issue Jul 11, 2018 · 12 comments · Fixed by #1250
Assignees

Comments

@samm82
Copy link
Collaborator

samm82 commented Jul 11, 2018

This table is called "Table 2", despite being the first table in the document. It should be updated to "Table 1" to match caseStudies and be correct.

product use

The rest of the tables then need to be shifted ie. the following should be tables 2 and 3:

other tables

@smiths
Copy link
Collaborator

smiths commented Jul 11, 2018

Yes, please update the generated tex so that the table number is correct. However, I have a feeling that this might be challenging. It doesn't happen often, but I vaguely recall running into issues like this in the past. It may be a weird interaction between LaTeX packages. It might not be easy to diagnose the problem and come up with a fix.

@smiths smiths assigned samm82 and unassigned smiths Jul 11, 2018
@samm82
Copy link
Collaborator Author

samm82 commented Aug 14, 2018

The correct table number is shown when the Table of Symbols (the only longtabu before the Product Use Table; the Tables of Units and Abbreviations/Acronyms use longtable*) is removed. I think this is because there isn't a caption specified for the Table of Symbols, but the figure number is still "1", so the next longtabu (the Product Use Table) gets incremented to "2".

@JacquesCarette
Copy link
Owner

Any recommendation on how to fix this?

@samm82
Copy link
Collaborator Author

samm82 commented Aug 15, 2018

We could make every table referable (ie. give them captions with their numbers), although this could have formatting issues for the LaTeX. This would also allow us to reference these tables directly in the future.

@JacquesCarette
Copy link
Owner

I think that yes, all tables should be referable. We should label all tables, but may indeed choose to have an empty caption (which should help with the formatting).

@samm82
Copy link
Collaborator Author

samm82 commented May 1, 2019

An update: out of the three tables that appear before this "Table 2" (Table of Units, Table of Symbols, and Abbreviations and Acronyms), "Table 1" is the only one that uses \begin{longtabu} (Table of Symbols); the other two use \begin{longtable*}. This prevents them from having figure numbers and throws an error if a caption is added to it. Labeling these tables seems redundant, since they are the only thing in their section, and the section title labels the table quite nicely, but I think the easiest and most consistent fix would be to add a caption to every table, which will include changing \begin{longtable*} to \begin{longtable}.

Thoughts? EDIT: Once I fix this, should I make a low priority issue to add an option for foregoing the caption? I think this will be a little difficult, since you can't prevent longtabu from incrementing the table count - it has to be done manually.

@smiths
Copy link
Collaborator

smiths commented May 1, 2019

@samm82, your recommendation seems to match with the comment from @JacquesCarette from last summer. You can create a table with a caption, and set the caption to an empty string.

@samm82
Copy link
Collaborator Author

samm82 commented May 1, 2019

I interpreted Dr. Carette's comment to have an "empty caption" to mean that there shouldn't be anything under the table, but I think an "empty caption" as in no description is straightforward enough. My one suspicion is that an empty string will cause "Table #:" to be displayed under the table, and the colon would be unwanted, but I'll check it out tomorrow.

@smiths
Copy link
Collaborator

smiths commented May 2, 2019

@samm82, you have a good point about the Table number. I think what we are talking about is the same interface in Drasil, but having an empty caption in Drasil. I'm sure @JacquesCarette will let us know what he is thinking. 😄

@samm82

This comment has been minimized.

@samm82
Copy link
Collaborator Author

samm82 commented May 2, 2019

The behaviour is changed so that every table is numbered (and labelled ie. "Table 1" in LaTeX) and the caption can be toggled ("Table 1" vs. "Table 1: Table of Units"). Will be closed with merge of #1250.

@JacquesCarette
Copy link
Owner

My opinion: good work @samm82 !

JacquesCarette pushed a commit that referenced this issue May 4, 2019
* Added Functional Requirements intro to all examples

* Updated cabal files from previous commit

* Removed deprecated note from FR1 in GlassBR; closes #877

* Bumped drasil-data version number

* SSP Functional Requirements (#1230)

* Updated requirements 1-3

* Removed the unnecessary/bad requirements

* Updated R4-R6

* Updated R7-R8

* Updated R9-R11

* Added table of inputs to output

* Fixed errors and warnings

* Added caption to new table

* Updated stable

* Added requirement about writing output to file

* Updated stable

* SSP Referable Goals (#1232)

* Updated stable - LCs in traceability matrix

* Added goalStmtDom so that goal statements can be made CIs

* Made referable concept instances out of the SSP goals

* Cleaned warnings and updated stable

* SSP Cleanup (#1234)

* Added missing citations of Karchewski paper, updated stable (LC traceability)

* Removed rigid finite element def

* Changed last use of SSA acronym to SSP

* Added ssp to acronym table, removed ssa

* Updated confusing description

* Signed my name

* updated stable

* Fixed warning causing failed build

* Updated stable

* Add build target to drasil-code generated Makefiles (#1239)

* Make Make build generator more abstract.

* Add support for Phony targets to make printer.

* Create smart constructors for Rules and Commands.

* Add build AST to drasil-code for generating Makefiles.

* Make file generation (for codegen) more flexible.

* Use drasil-build in drasil-code to expose a renderer for build scripts.

* Enable makefile generation for drasil-code codegen. (Only 'run' target at the moment)

* Rename RunName to BuildName and cleanup AST.

* Add infrastructure for a language's BuildConfig.

* Add buildConfig field to language Configs.

* Enable build target for code Makefiles.

* Generate build target even if the language requires no building to have a consistent make target when invoked with no arguments.

* Fixed list concatenation in Requirements.hs

* Improved caption generated for tables; as per #833
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants