SSP DDs 1-3 #1201
Merged
SSP DDs 1-3 #1201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nstituent equation
smiths
reviewed
Apr 16, 2019
| \item{${ℓ_{b}}$ is the total base length of a slice (m)} | ||
| \item{$i$ is the index (Unitless)} | ||
| \item{${y_{wt}}$ is the y ordinate (m)} | ||
| \item{${y_{slip}}$ is the y ordinate (m)} |
There was a problem hiding this comment.
I am going to create a separate issue about the use of the term y ordinate. I think we should just say y coordinate. y ordinate is not a term that is used, as far as I can tell. ordinate is used as a name of the vertical axis, but y ordinate is redundant. I do not want to confuse this pull request with this issue, so I'll make the issue a separate one.
JacquesCarette
approved these changes
Apr 16, 2019
|
Can you merge master in? There are conflicts now. |
JacquesCarette
approved these changes
Apr 16, 2019
|
Merged master, this should be good to go. |
|
As soon as Travis agrees with you... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the first 3 DDs in SSP. These are the ones that had multiple equations in the manual version, so I have split them up into a DD per equation as per discussion in #1174.