Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SWHS] Fixed Newton's Law of Cooling #1822

Merged
merged 4 commits into from
Aug 14, 2019
Merged

[SWHS] Fixed Newton's Law of Cooling #1822

merged 4 commits into from
Aug 14, 2019

Conversation

samm82
Copy link
Collaborator

@samm82 samm82 commented Aug 12, 2019

Fixed Newton's Law of Cooling from the swhsTMs branch.

Closes #1479

JacquesCarette
JacquesCarette reviewed Aug 14, 2019
View reviewed changes
Copy link
Owner

@JacquesCarette JacquesCarette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes look fine to me, but this really feels like a change that @smiths should approve.

smiths
smiths approved these changes Aug 14, 2019
View reviewed changes
Copy link
Collaborator

@smiths smiths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me. As a side note, the refinement of Theoretical Model for Newton's Law of Cooling (TM:nwtnCooling) to two general definitions (GD: htFluxWaterFromCoil and GD: htFluxPCMFromWater) is another example for us to consider when discussing #1814 and #1829.

@smiths smiths merged commit a74c2fc into master Aug 14, 2019
@smiths smiths deleted the swhsNewtonsLawOfCooling branch August 14, 2019 20:33
@smiths smiths mentioned this pull request Aug 15, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JacquesCarette JacquesCarette JacquesCarette left review comments

@smiths smiths smiths approved these changes

Assignees

@smiths smiths

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SWHS: Move Newton’s Law of Cooling from GD to TM
3 participants
@samm82 @smiths @JacquesCarette