Implementing new combinators into dblPendulum #2479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JacquesCarette
requested changes
May 18, 2021
|
This should be okay to merge now (and resolve the requested changes). I know we already discussed changing the naming scheme and moving some combinators in other issues, but I think it would be easier to just start on a fresh branch. |
JacquesCarette
approved these changes
May 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes #2399
Contributes #2476
Implemented some higher level combinators in the pendulum example. I think
compoundNCallows for a level 3 combination betweenNamedIdeas, but I had to place it into the database. Although I'm not sure ifAssumptions.hsis the best place for it.