Fix d_offset constraint in Projectile
#3192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JacquesCarette should review the code before we merge the pull request. |
JacquesCarette
approved these changes
Dec 22, 2022
There was a problem hiding this comment.
I'm guessing that the change wrt Rational is likely that you removed the last reference to something typed Rational. I had already removed a lot (it was a hack - it really was meant for things that are rational, not real). I am surprised that it was your change that triggered this, but hey, it is an expected improvement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3187
This change did not affect the generated code, but removed the line "Successfully matched Rational with Float." (or its equivalent) from the designLogs for projectile_s_l_nol_u_u_v_f.