#3252 Preparation Works #3900
Merged
#3252 Preparation Works #3900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Update stack.yaml to fix one compatible error. 2. Fix some minor grammar and clarity typos.
|
Could you split this into 2 PRs please? One for the minor fixes, and one for the stack changes. We don't like PRs that do more than one thing at once. |
Remove stack changes and split it into another PR
Done. However, without this change, my Drasil does not have a successful execution. (Testing may fail.) |
JacquesCarette
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@JacquesCarette @samm82 The official solution of issue #3252 comes tonight, this is to improve the quality of contributions.