Modified the codegenTest target to check diff with stable
#3909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that the generated code for GOOL tests matches that in `stable/gooltest`. `codegenTest` is already in our CI from the looks of it, so this should improve our CI.
JacquesCarette
approved these changes
Aug 3, 2024
This was referenced Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that the generated code for GOOL tests matches that in
stable/gooltest.codegenTestis already in our CI from the looks of it, so this should prevent the cases we've had wherebuild/gooltestdoesn't matchstable/gooltest.Next steps:
codegenTest_gentomake pr_ready.codegenTesttomake pr_ready, as it requires that the local machine has the compilers installed for all compiled targets.build/gooltestfolder. We need to add amake codegenTest_stabilizeoption.Closes #3678
Contributes to #3387