Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaned up a bit of the Julia renderer #3937

Merged
merged 1 commit into from
Aug 23, 2024
Merged

Cleaned up a bit of the Julia renderer #3937

merged 1 commit into from
Aug 23, 2024

Conversation

B-rando1
Copy link
Collaborator

I split up a few functions, added some comments, etc.

Notes:

  • I noticed that the getUsing function and things relating to it are only used by the C++ renderer, so I removed them from the Julia renderer.
  • I removed the TODO: think about splitting up CodeType comment. I'm not sure if that is the way we should go, and if it is then it should be an issue, not a comment.
  • I removed the block comment describing Julia's abstract types. I do still think that adding sub-types to GOOL would be a neat project, but there's no reason for that comment to be there.
  • I created the jlGlobalDec function that jlAssign, jlSubAssign, and jlIncrement all use.
  • I removed spaces at the end of lines and evened out the spacing in one or two places.

I split up a few functions, added some comments, etc.
@JacquesCarette JacquesCarette merged commit 243cc8f into main Aug 23, 2024
5 checks passed
@JacquesCarette JacquesCarette deleted the JuliaCleanup branch August 23, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants