Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3252 Sentence Reworking (for the Glassbr Example) #3952

Merged
merged 6 commits into from
Sep 9, 2024

Conversation

daijingz
Copy link
Contributor

@daijingz daijingz commented Sep 8, 2024

Now these changes are much more worthy.

@JacquesCarette @samm82 I split all updates by each Drasil example, and now you can see these updates become much more worthy-to-change.
For the hghc example, I only found a few (very few) constructed sentences in the folder drasil-example. (I did not find any potential places to change) I just skip this example, is that OK?

1. Update stack.yaml to fix one compatible error.
2. Fix some minor grammar and clarity typos.
Remove stack changes and split it into another PR
Extract the most worthy places to re-format sentences, and rework on them.
Remove dependency changes on stack.yaml.
Copy link
Owner

@JacquesCarette JacquesCarette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know about "much more worthy", but they are legitimate small improvements.

@JacquesCarette JacquesCarette merged commit af302b6 into JacquesCarette:main Sep 9, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants