Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes Elements in Contents' Enumerations Referable #892

Merged
merged 1 commit into from
Jul 23, 2018

Conversation

Mornix
Copy link
Collaborator

@Mornix Mornix commented Jul 16, 2018

This PR is part of #562. It's a followup to #845 by adding support to Contents' Enumeration to make individual items referable. It "connects" the references in Contents to those in LayoutObj. Currently, nothing uses Enumeration references and all examples have been updated using the convenience functions noRefs and noRefsLT to maintain current behaviour.

…kes individual "items" in Contents Enumerations referable.

Adds noRefs and noRefsLT as convenience functions to make a list of ListTuples without being referable.
Updated examples accordingly.
Copy link
Owner

@JacquesCarette JacquesCarette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can tell, this is fine. But it conflicts with other changes, so I'll have to do a careful merge 'by hand' as it were.

@JacquesCarette JacquesCarette merged commit 499239c into master Jul 23, 2018
@JacquesCarette
Copy link
Owner

Merging this was mildly tricky -- there is a real chance I made a mistake. @Mornix please double-check!

@JacquesCarette JacquesCarette deleted the refenum_contents branch July 23, 2018 00:40
@Mornix
Copy link
Collaborator Author

Mornix commented Jul 23, 2018

Yup! The merge looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants