Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Small PR] Renamed 'mkDataDef' to 'mkQuantDef' #972

Merged
merged 2 commits into from
Aug 1, 2018

Conversation

samm82
Copy link
Collaborator

@samm82 samm82 commented Aug 1, 2018

To better represent what it does. Closes #926

@samm82
Copy link
Collaborator Author

samm82 commented Aug 1, 2018

@JacquesCarette not sure why the build is failing - make runs clean on my machine

@JacquesCarette
Copy link
Owner

The log has symptoms of network outage -- somehow hackage could not be reached just then. Since you checked this in, I think you can restart the run, I don't seem to be able to.

@samm82 samm82 closed this Aug 1, 2018
@samm82 samm82 reopened this Aug 1, 2018
@samm82
Copy link
Collaborator Author

samm82 commented Aug 1, 2018

I tried closing and reopening the PR, and that didn't work, so I pushed an empty commit to trigger a rebuild which did the trick 👍

@JacquesCarette JacquesCarette merged commit 7777ec2 into master Aug 1, 2018
@JacquesCarette JacquesCarette deleted the renamemkDataDef branch August 1, 2018 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants