Enable referencing for data types #979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…instance of Contents
…e and potential solutions)
…on as LabelledContent instead of Contents
…l need to be pulled out
… for referencing (removes some uses of missingP hack)
…; continue to clear log
JacquesCarette
requested changes
Aug 8, 2018
code/Makefile
Outdated
| @@ -27,7 +27,7 @@ SWHS_EXE = swhs | |||
| SSP_EXE = ssp | |||
| GAME_EXE = chipmunkdocs | |||
|
|
|||
| DIRS = $(TINY_DIR) $(GLASS_DIR) $(NoPCM_DIR) $(SWHS_DIR) $(SSP_DIR) $(GAME_DIR) $(DATA_DIR) $(LANG_DIR) $(DOCL_DIR) $(EXAM_DIR) $(CODE_DIR) $(GEN_DIR) $(PRINT_DIR) | |||
There was a problem hiding this comment.
It was removed because of the error with GlassBR and apparently never added back in - I'll fix then merge master.
JacquesCarette
approved these changes
Aug 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the interest of getting addLabels merged into master with working links as soon as possible, in commit 9cb8887,
RefTypewas reinserted as a field forLabels. Please follow the messages in #971 to see the reasoning for doing so.