Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🐛 Add the temp directory created to the safe directory list #1701

Merged
merged 1 commit into from
Sep 28, 2024

Conversation

JamesIves
Copy link
Owner

Description

Adds the temp workflow directory to the safe list of directories. A deployment failure can occur here depending on the type of files moved around by the workflow, and as such we need to mark this directory as safe too to prevent dubious ownership.

Testing Instructions

This has been validated on a test branch. I have also added a replicate PR in the integration test to validate root level deployments to ensure they continue to work. It doesn't repro this bug, but it's something at least.

Additional Notes

Closes #1694

@github-actions github-actions bot added bug 🐝 This issue describes a bug. fix 🐝 This change fixes a bug. labels Sep 28, 2024
Copy link

codecov bot commented Sep 28, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 96.02%. Comparing base (b182543) to head (6647680).

Files with missing lines Patch % Lines
src/worktree.ts 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1701      +/-   ##
==========================================
- Coverage   96.32%   96.02%   -0.30%     
==========================================
  Files           7        7              
  Lines         299      302       +3     
  Branches       83       83              
==========================================
+ Hits          288      290       +2     
- Misses         11       12       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JamesIves JamesIves merged commit 74a410d into dev Sep 28, 2024
9 of 19 checks passed
@JamesIves JamesIves deleted the fix-worktree-safe-dir branch September 28, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐝 This issue describes a bug. fix 🐝 This change fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: 🐝 Cannot deploy from the root of the repo (?)
1 participant