Skip to content

Commit

Permalink
Update expected codecov flags count to 19 (jaegertracing#5811)
Browse files Browse the repository at this point in the history
## Which problem is this PR solving?
We are now running 19 different uploads of codecov

<img width="403" alt="image"
src="https://github.com/user-attachments/assets/d31594c5-6b76-4e12-bb98-60902addd976">

However, the current configuration was only waiting for 11, which
resulted in false positives like this:

<img width="904" alt="image"
src="https://github.com/user-attachments/assets/182f1578-53aa-476c-80e6-2d71428ce66c">

I.e. a comment about non-covered code which is actually covered, but its
result uploads came after the 11 other results.

## Description of the changes
- Bump expected count to 19, the current number of distinct
flags/uploads.

Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Jared Tan <jian.tan@daocloud.io>
  • Loading branch information
yurishkuro authored and JaredTan95 committed Aug 8, 2024
1 parent 470d70d commit bd8ebd3
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .codecov.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
codecov:
notify:
require_ci_to_pass: yes
after_n_builds: 11
after_n_builds: 19
strict_yaml_branch: main # only use the latest copy on the main branch

ignore:
Expand Down

0 comments on commit bd8ebd3

Please sign in to comment.