fixed up some mobile issues from the move

JediWattson · Oct 21, 2022 · 6b9accf · 6b9accf
1 parent 799cf6c
commit 6b9accf
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 7 deletions.
diff --git a/src/components/AttachmentCarousel.js b/src/components/AttachmentCarousel.js
@@ -178,7 +178,7 @@ class AttachmentCarousel extends React.Component {
                     canSwipeLeft={!this.state.isBackDisabled}
                     canSwipeRight={!this.state.isForwardDisabled}
                     onPress={() => this.canUseTouchScreen && this.onShowArrow(!this.state.showArrows)}
-                    onCycleThroughAttachments={this.cycleThroughAttachments}
+                    onSwipe={this.cycleThroughAttachments}
                 >
                     <AttachmentView onPDFPress={() => this.onShowArrow(!this.state.showArrows)} sourceURL={this.state.sourceURL} file={this.state.file} />
                 </Carousel>

diff --git a/src/components/Carousel/index.native.js b/src/components/Carousel/index.native.js
@@ -3,7 +3,6 @@ import {PanResponder, Dimensions, Animated} from 'react-native';
 import PropTypes from 'prop-types';
 
 import styles from '../../styles/styles';
-import CONST from '../../CONST';
 
 const propTypes = {
     children: PropTypes.element.isRequired,
@@ -32,12 +31,8 @@ class Carousel extends Component {
         this.pan = new Animated.Value(0);
 
         this.panResponder = PanResponder.create({
-            onMoveShouldSetPanResponderCapture: (_event, gestureState) => {
-                if (gestureState.dy < CONST.COMPOSER_MAX_HEIGHT) { return; }
-                return true;
-            },
-
             onStartShouldSetPanResponder: () => true,
+
             onPanResponderMove: (event, gestureState) => Animated.event([null, {
                 dx: this.pan,
             }], {useNativeDriver: false})(event, gestureState),
@@ -59,6 +54,7 @@ class Carousel extends Component {
                     if (!finished) {
                         return;
                     }
+
                     this.props.onSwipe(deltaSlide);
                     this.pan.setValue(slideLength);
                     Animated.timing(this.pan, {useNativeDriver: false, duration: 100, toValue: 0}).start();

diff --git a/src/components/PDFView/index.native.js b/src/components/PDFView/index.native.js
@@ -139,6 +139,7 @@ class PDFView extends Component {
                             onError={this.initiatePasswordChallenge}
                             password={this.state.password}
                             onLoadComplete={this.finishPdfLoad}
+                            onPageSingleTap={this.props.onPress}
                         />
                     </TouchableWithoutFeedback>
                 )}