Skip to content

Commit

Permalink
Merge pull request Expensify#13037 from Expensify/maxence-fkavors
Browse files Browse the repository at this point in the history
Move KAV outside of Freeze view
  • Loading branch information
marcaaron authored Nov 30, 2022
2 parents 6a50344 + d5eebf0 commit 820e876
Showing 1 changed file with 12 additions and 15 deletions.
27 changes: 12 additions & 15 deletions src/pages/home/ReportScreen.js
Original file line number Diff line number Diff line change
Expand Up @@ -225,19 +225,17 @@ class ReportScreen extends React.Component {
const animatePlaceholder = !freeze;

return (
<Freeze
freeze={freeze}
placeholder={(
<ScreenWrapper
style={screenWrapperStyle}
>
<ReportHeaderSkeletonView animate={animatePlaceholder} />
<ReportActionsSkeletonView animate={animatePlaceholder} containerHeight={this.state.skeletonViewContainerHeight} />
</ScreenWrapper>
)}
<ScreenWrapper
style={screenWrapperStyle}
>
<ScreenWrapper
style={screenWrapperStyle}
<Freeze
freeze={freeze}
placeholder={(
<>
<ReportHeaderSkeletonView animate={animatePlaceholder} />
<ReportActionsSkeletonView animate={animatePlaceholder} containerHeight={this.state.skeletonViewContainerHeight} />
</>
)}
>
<FullPageNotFoundView
shouldShow={!this.props.report.reportID}
Expand Down Expand Up @@ -282,7 +280,6 @@ class ReportScreen extends React.Component {
if (skeletonViewContainerHeight === 0) {
return;
}

reportActionsListViewHeight = skeletonViewContainerHeight;
this.setState({skeletonViewContainerHeight});
}}
Expand Down Expand Up @@ -318,8 +315,8 @@ class ReportScreen extends React.Component {
)}
</View>
</FullPageNotFoundView>
</ScreenWrapper>
</Freeze>
</Freeze>
</ScreenWrapper>
);
}
}
Expand Down

0 comments on commit 820e876

Please sign in to comment.