Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix visibility of selection handles in iOS when text is RTL or BiDi #1331

Merged
merged 9 commits into from
Jun 19, 2024
Merged

Fix visibility of selection handles in iOS when text is RTL or BiDi #1331

merged 9 commits into from
Jun 19, 2024

Commits on Jun 18, 2024

  1. adjusted check of visibility of selection handles in iOS

    @mazunin-v-jb
    mazunin-v-jb committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    aa51431 View commit details
    Browse the repository at this point in the history

  2. moved HeightToleranceFactor into separate private constant

    @mazunin-v-jb
    mazunin-v-jb committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    b6ca0fa View commit details
    Browse the repository at this point in the history

  3. refactored method isSelectionHandleInVisibleBound in uikit source set… 

    …, added test screen in Components/TextField with RTL and BiDi examples
    @mazunin-v-jb
    mazunin-v-jb committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    66de529 View commit details
    Browse the repository at this point in the history

  4. fixed incorrect naming in labels in example

    @mazunin-v-jb
    mazunin-v-jb committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    26554d9 View commit details
    Browse the repository at this point in the history

  5. (WIP) Created tests file for Selection Handles for RTL and BiDi text

    @mazunin-v-jb
    mazunin-v-jb committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    323b85b View commit details
    Browse the repository at this point in the history

  6. Extracted check of selection handle visibility to make it testabled i… 

    …nto separate method, added test cases for that method
    @mazunin-v-jb
    mazunin-v-jb committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    6b276b0 View commit details
    Browse the repository at this point in the history

  7. removed debug print

    @mazunin-v-jb
    mazunin-v-jb committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    a016280 View commit details
    Browse the repository at this point in the history

  8. renamed test cases for better readability

    @mazunin-v-jb
    mazunin-v-jb committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    6527ad5 View commit details
    Browse the repository at this point in the history

  9. made tests more readable

    @mazunin-v-jb
    mazunin-v-jb committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    4f3ac09 View commit details
    Browse the repository at this point in the history