Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scene scale #1547

Merged
merged 1 commit into from
Sep 6, 2024
Merged

Fix scene scale #1547

merged 1 commit into from
Sep 6, 2024

Conversation

ASalavei
Copy link
Collaborator

@ASalavei ASalavei commented Sep 6, 2024

On some devices, iOS uses a canvas larger than the physical screen resolution of the device to perform rendering operations. The scale factor between points and canvas pixels is represented by UIScreen.scale.
UIScreen.nativeScale is used to represent the scale factor between points and physical screen pixels. The nativeScale also represents how iOS compresses the canvas image to fit the real device screen.
Considering these factors, the DP should represent canvas pixels (not physical device pixels) to match the native iOS canvas density.

Fixes - Scene scale

Fixes: https://youtrack.jetbrains.com/issue/CMP-6690

Release Notes

Fixes - iOS

  • (prerelease fix) Fix "White bars on sides on some devices"

@igordmn
Copy link
Collaborator

igordmn commented Sep 6, 2024

Please, provide more information, plus Release notes

@ASalavei ASalavei merged commit 3d403aa into jb-main Sep 6, 2024
6 checks passed
@ASalavei ASalavei deleted the andrei.salavei/fix-scene-scale branch September 6, 2024 13:21
@igordmn
Copy link
Collaborator

igordmn commented Sep 19, 2024

Added forgotten "### Fixes - iOS"

@igordmn
Copy link
Collaborator

igordmn commented Sep 19, 2024

(prerelease fix) Fix compose scene scale to match iOS natural screen scale.

changed to

(prerelease fix) Fix "White bars on sides on some devices".

due JetBrains/compose-multiplatform#5142 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants