-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expect androidx.compose.material3.AlertDialog
in common
#710
Conversation
...l3/material3/src/androidMain/kotlin/androidx/compose/material3/AndroidAlertDialog.android.kt
Show resolved
Hide resolved
dd31f2f
to
5f314b1
Compare
After switching to
Now dialogs are limited in width, although using |
From spec:
The code: Line 332 in 3431324
I'm not sure from what component you've switched, but current state looks as expected, behaves per spec and should be equal to Google's implementation (it's the same code actually). Also please note that |
thanks, this solved my problem. I was not attentive enough to the properties of this flag. |
…alog` in common (#710) * Expect AlertDialog in common * Revert Android formatting * Add comment about binary compatibility
….AlertDialog` in common (#710) * Expect AlertDialog in common * Revert Android formatting * Add comment about binary compatibility
* Expect AlertDialog in common * Revert Android formatting * Add comment about binary compatibility
It's upstreaming of JetBrains#710. This API is already available from common since Compose Multiplatform 1.5.0 Test: N/A Relnote: Make `androidx.compose.material3.AlertDialog` available from common source set Change-Id: Ia33f513f472f6d200de922fdef0fd2f73f62b007
Proposed Changes
AlertDialog
in commonDialog
from Expect Dialog in common #632Testing
Test: TBD
Issues Fixed