Expect DatePickerDialog in common
#745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatkovIvan
force-pushed
the
ivan.matkov/datepicker-dialog
branch
from
455149c
to
178ca9a
Compare
MatkovIvan
changed the title
DatePickerDialog from androidDatePickerDialog in common
igordmn
approved these changes
Aug 11, 2023
igordmn
pushed a commit
that referenced
this pull request
Nov 15, 2023
* Copy DatePickerDialog from android * Expect DatePickerDialog in common * Add DatePickerDialog sample to mpp
igordmn
pushed a commit
that referenced
this pull request
Nov 16, 2023
#745) * Copy DatePickerDialog from android * Expect DatePickerDialog in common * Add DatePickerDialog sample to mpp
igordmn
pushed a commit
that referenced
this pull request
Jan 30, 2024
* Copy DatePickerDialog from android * Expect DatePickerDialog in common * Add DatePickerDialog sample to mpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Copy
DatePickerDialogimplementation from Android.This cannot be in common yet (see #736) because ofSolved in #746usePlatformDefaultWidthparameter in default arguments.Testing
Test: Try to use
DatePickerDialogin commonIssues Fixed
Fixes (partially) JetBrains/compose-multiplatform#2037 (comment)