First Dart Macro change #903
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -119,6 +119,9 @@ public final class DartAnalysisServerService implements Disposable { | |||
| private static final long ANALYSIS_IN_TESTS_TIMEOUT = TimeUnit.SECONDS.toMillis(10); | |||
| private static final long TESTS_TIMEOUT_COEFF = 10; | |||
|
|
|||
| // LSP over Legacy Dart Analysis Protocol | |||
| public static final long LSP_MESSAGE_TEXT_DOCUMENT_CONTENT_TIMEOUT = TimeUnit.SECONDS.toMillis(100); | |||
There was a problem hiding this comment.
Isn't it too much ;)?
There was a problem hiding this comment.
Reduced to 50, 10 would probably be sufficient in most cases, just trying to be careful. Remember, Dart is single-threaded and files could be large.
|
|
||
| import org.dartlang.analysis.server.protocol.RequestError; | ||
|
|
||
| public interface LSPDartTextDocumentContentConsumer extends Consumer { |
There was a problem hiding this comment.
Are LSPDartTextDocumentContentConsumer and LSPDartTextDocumentContentProcessor names generated?
If they are hand-written, are you ok with DartLspTextDocumentContentConsumer and DartLspTextDocumentContentProcessor? Not a big deal if not.
| @@ -0,0 +1,16 @@ | |||
| // Copyright 2000-2024 JetBrains s.r.o. and contributors. Use of this source code is governed by the Apache 2.0 license. | |||
There was a problem hiding this comment.
I don't know if copyrights are still needed in each file. But if so, I guess it should be the same as in neighbor files (Copyright (c) 2024, the Dart project authors...)
…ervice.lspMessage_dart_textDocumentContent(..) With the associated consumer and processor patterns for communication with the Dart SDK (Dart Analysis Server)
intellij-monorepo-bot
pushed a commit
that referenced
this pull request
May 16, 2024
…ysisServerService.lspMessage_dart_textDocumentContent() close #903 (cherry picked from commit 1c825c586c0197369497d129a0040c2eeb7b9ddc) GitOrigin-RevId: 46e3d991745ef3a622dd06e01f59a4ecf0072531
intellij-monorepo-bot
pushed a commit
that referenced
this pull request
May 17, 2024
…ysisServerService.lspMessage_dart_textDocumentContent() close #903 (cherry picked from commit 1c825c586c0197369497d129a0040c2eeb7b9ddc) GitOrigin-RevId: ef50e62cad6e50daf55b483088cf79b8c6b1cf8d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addition of the (currently unused)
DartAnalysisServerService.lspMessage_dart_textDocumentContent(..), with the associated consumer and processor patterns for communication with the Dart SDK (Dart Analysis Server)dart-lang/language#1482
https://dart-review.googlesource.com/c/sdk/+/345420
https://dart-review.googlesource.com/c/sdk/+/347023