refactor: create re-usable Shadowsocks service #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbruens
changed the title
sbruens
changed the title
fortuna
reviewed
Sep 10, 2024
This reverts commit 1259af8.
fortuna
approved these changes
Sep 16, 2024
| metrics ServiceMetrics | ||
| ciphers CipherList | ||
| natTimeout time.Duration | ||
| replayCache *ReplayCache |
There was a problem hiding this comment.
Yes, it can. The implementation of ReplayCache includes a safeguard against nil pointers:
outline-ss-server/service/replay.go
Line 83 in 4463b38
That's probably why we don't explicitly safeguard against it in NewShadowsocksStreamAuthenticator(). I'm not sure if this pattern is idiomatic in Go?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This service will be shared by Caddy module in forthcoming PR.