Draft : Started to work on ReadRangeService #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
_required = (
"presentValue",
"statusFlags",
"eventState",
"outOfService",
"polarity",
)
BinaryOutputObject
_required = (
"presentValue",
"statusFlags",
"eventState",
"outOfService",
"polarity",
"priorityArray",
"relinquishDefault",
"currentCommandPriority",
)
BinaryValueObject
_required = (
"presentValue",
"priorityArray",
"statusFlags",
"eventState",
"outOfService",
)
BinaryValueObjectCmd
_required = "priorityArray"
…ices numbers do not match. This fix a bug in the determination of services supported
|
@JoelBender comments welcome |
…ices numbers do not match. This fix a bug in the determination of services supported
|
@JoelBender I removed the "draft" status. I commented out the do_ReadRangeRequest work done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of, I found a bug on the determination of ServicesSupported. This is fixing it. (hope so)
The Local trendlog object gets created in my scripts but the client sees a problem
javax.baja.driver.history.ArchiveException: History type cannot be determined from device!
This is next step