Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix race condition in protected decorator #14

Merged
merged 4 commits into from
May 7, 2024
Merged

Fix race condition in protected decorator #14

merged 4 commits into from
May 7, 2024

Conversation

Jonxslays
Copy link
Owner

This PR fixes a race condition in the protected decorator, which was caused by using a single client, starting and then closing the session, while concurrent requests were coming in.

Removed the optionality on handler types.

Added the ability to use the client as an async context manager.

Resolves #12
Resolves #13

@Jonxslays Jonxslays added the bug Something isn't working label May 7, 2024
@Jonxslays Jonxslays changed the title Fix race condition in protected decorator. Fix race condition in protected decorator May 7, 2024
@Jonxslays Jonxslays merged commit 8f161fb into master May 7, 2024
19 checks passed
@Jonxslays Jonxslays deleted the issue/13 branch May 7, 2024 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
1 participant