Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sermons View Page builder section over usage #838

Closed
bcordis opened this issue Mar 26, 2021 · 4 comments
Closed

Sermons View Page builder section over usage #838

bcordis opened this issue Mar 26, 2021 · 4 comments
Assignees
Milestone

Comments

@bcordis
Copy link
Member

bcordis commented Mar 26, 2021

Looking at the code and following how it's being used. Right now it looks like we are calling it but we don't need it all the time.

Need to look at seeing if we could narrow the usage down.

site\views\sermon\view.html.php line 288

@bcordis bcordis added this to the v9.2.x milestone Mar 26, 2021
@tomfuller2
Copy link
Member

Looks like only call it once in sermon/view.html.php and that is only if the user has turned on expert mode. Do we still use expert mode?

@bcordis
Copy link
Member Author

bcordis commented Apr 1, 2021

I'm not sure we use it any more and the way it's coded right now it runs the through the code every time. Lot of over work as it's not used.

@bcordis
Copy link
Member Author

bcordis commented Apr 2, 2021

Man, we are running into the same problem within the model presenting the same over usage of the processes. Looks like we need to optimize them both.

@bcordis
Copy link
Member Author

bcordis commented May 2, 2021

@tomfuller2 I think this would be a fix for us now.

@bcordis bcordis closed this as completed May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants