Support Val{k} as second argument in diagm #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #255 +/- ##
==========================================
- Coverage 89% 88.95% -0.06%
==========================================
Files 36 36
Lines 2619 2625 +6
==========================================
+ Hits 2331 2335 +4
- Misses 288 290 +2
Continue to review full report at Codecov.
|
c42f
approved these changes
Jul 27, 2017
| T = eltype(v) | ||
| exprs = [i == j ? :(v[$i]) : zero(T) for i = 1:S[1], j = 1:S[1]] | ||
| ind = diagind(Snew1, Snew1, D) |
There was a problem hiding this comment.
Nice. I didn't know about diagind.
test/linalg.jl
Outdated
| @@ -40,6 +40,8 @@ using StaticArrays, Base.Test | |||
|
|
|||
| @testset "diagm()" begin | |||
| @test @inferred(diagm(SVector(1,2))) === @SMatrix [1 0; 0 2] | |||
| @test @inferred(diagm(SVector(1,2,3), Val{2})) == diagm([1,2,3], 2) | |||
There was a problem hiding this comment.
A minor thing - might be worth adding a type assert here ::SMatrix on the left hand side outside the @inferred to assert that these come out as static arrays.
There was a problem hiding this comment.
Good idea. Just made changes accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements
diagm(::SVector, ::Type{Val{k}}), which type-stably creates a matrix with a specifiedkth super-or sub-diagonal. Previously there was onlydiagm(::SVector)without the second argument.