Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport invalidation fixes to 0.18.19 #905

Merged
merged 2 commits into from
Apr 12, 2024
Merged

Backport invalidation fixes to 0.18.19 #905

merged 2 commits into from
Apr 12, 2024

Commits on Apr 12, 2024

  1. Delete unnecessary methods to fix invalidations 

    - Base.keys() already works on AbstractDict's so we don't need one for
  Accumulator.
- Base.eltype() is already defined for AbstractArray's and CircularBuffer is an
  AbstractVector so it doesn't need to define it again.
- A Base.convert() from AbstractArray to Array is already defined:
  https://github.com/JuliaLang/julia/blob/1ae41a2c0a3ba49d4b39dc4933dddf952b5f7f3c/base/array.jl#L612
    @JamesWrigley
    JamesWrigley committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    2dbfb80 View commit details
    Browse the repository at this point in the history

  2. Bump version to 0.18.19

    @JamesWrigley
    JamesWrigley committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    91a76c9 View commit details
    Browse the repository at this point in the history