Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] OrderedGeneralDict #52

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

eulerkochy
Copy link
Member

This is a modified version of #39 .

Work remaining --
I have to fix the OrderedSet tests, which broke because of this change

@vtjnash
Copy link

vtjnash commented Aug 11, 2020

Wouldn't this be quite inefficient, with the need to store the keys twice, and to double the rehashing logic?

@PallHaraldsson
Copy link
Contributor

I was benchmarking this and see it's incomplete:

(@v1.6) pkg> add OrderedCollections#06cc1db


(20/100) benchmarking "empty! OrderedGeneralDict() 10^4 elem Int64"...
[..]
ERROR: MethodError: no method matching (OrderedGeneralDict{Float64, Float64, DT} where DT<:AbstractDict{Float64, Int32})(::Vector{Pair{Float64, Float64}})

As I'm running late for including in Julia 1.6 and just discovered this new one, I'm probably going to skip it. Unless you know it should be much better. Any idea how incomplete it is? We could always change the ordered dict implementation in Base later, after guarantee in, and I'm conflicted which to start with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants