Allow arguments to displaysize on 0.4 #1060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -165,11 +165,6 @@ function getprintedwidth(maxwidths::Vector{Int}) # -> Int | |||
| return totalwidth | |||
| end | |||
|
|
|||
| # For Julia < 0.5 | |||
| if VERSION < v"0.5.0-dev+2023" | |||
There was a problem hiding this comment.
That function doesn't exist in Compat, only the one without any arguments (I didn't include it there since it's a bit a cheating: io isn't used at all).
There was a problem hiding this comment.
Ah, good catch, thanks. Fixed in another commit.
ararslan
force-pushed
the
aa/displaysize
branch
from
22db71d
to
619b320
Compare
|
The 0.6 AppVeyor failure is both unrelated and strange. |
|
Ah, that's JuliaLang/julia#17932. We need to investigate this. (I've changed the title, since arguments were already allowed, just the function definition failed.) |
maximerischard
pushed a commit
to maximerischard/DataFrames.jl
that referenced
this pull request
Sep 28, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1058