Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add not to indexing #1847

Merged
merged 23 commits into from
Jun 21, 2019
Merged

Add not to indexing #1847

merged 23 commits into from
Jun 21, 2019

Conversation

bkamins
Copy link
Member

@bkamins bkamins commented Jun 10, 2019

This is not finished yet and I will add a list of changes it does.
In general I add Not for indexing + remove deletecols! as it is obsolete with Not + clean up several related methods.

@bkamins bkamins mentioned this pull request Jun 10, 2019
src/abstractdataframe/abstractdataframe.jl Show resolved Hide resolved
src/abstractdataframe/abstractdataframe.jl Outdated Show resolved Hide resolved
src/dataframe/dataframe.jl Show resolved Hide resolved
src/dataframe/dataframe.jl Outdated Show resolved Hide resolved
src/dataframe/dataframe.jl Outdated Show resolved Hide resolved
src/dataframe/dataframe.jl Outdated Show resolved Hide resolved
src/dataframe/dataframe.jl Outdated Show resolved Hide resolved
src/dataframe/dataframe.jl Outdated Show resolved Hide resolved
@bkamins
Copy link
Member Author

bkamins commented Jun 15, 2019

This PR should be good to have a look at.

Notes:

  • it supports Not for row and column indexing
  • it does not support Not in setindex! (this should be done in a separate PR that cleans up setindex! that should be merged before the next release)
  • in the long run all codes related to indexing should be refactored to make the design simpler I think, but this can be done after 1.0 release as discussed earlier

Test on nightly fail because of InteractiveUtils.jl not-found error (I did not investigate into it but I think this is unrelated).

@bkamins bkamins changed the title WIP: add not to indexing Add not to indexing Jun 19, 2019
Project.toml Outdated Show resolved Hide resolved
src/abstractdataframe/abstractdataframe.jl Outdated Show resolved Hide resolved
src/abstractdataframe/abstractdataframe.jl Outdated Show resolved Hide resolved
src/dataframe/dataframe.jl Outdated Show resolved Hide resolved
src/dataframe/dataframe.jl Outdated Show resolved Hide resolved
src/dataframe/dataframe.jl Outdated Show resolved Hide resolved
src/deprecated.jl Show resolved Hide resolved
src/other/index.jl Outdated Show resolved Hide resolved
src/other/index.jl Show resolved Hide resolved
test/duplicates.jl Outdated Show resolved Hide resolved
test/duplicates.jl Outdated Show resolved Hide resolved
test/iteration.jl Show resolved Hide resolved
src/abstractdataframe/abstractdataframe.jl Outdated Show resolved Hide resolved
src/dataframe/dataframe.jl Outdated Show resolved Hide resolved
src/dataframe/dataframe.jl Outdated Show resolved Hide resolved
src/dataframe/dataframe.jl Outdated Show resolved Hide resolved
src/dataframe/dataframe.jl Outdated Show resolved Hide resolved
bkamins and others added 2 commits June 21, 2019 11:45
Co-Authored-By: Milan Bouchet-Valat <nalimilan@club.fr>
@bkamins bkamins merged commit b63d270 into JuliaData:master Jun 21, 2019
@bkamins bkamins deleted the add_not_to_indexing branch June 21, 2019 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants