-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rule for cumprod
#420
Merged
Merged
Add rule for cumprod
#420
Changes from 14 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
7dc0e85
cumprod, take 1
mcabbott 4b4c347
fix a type instability
mcabbott c5db487
tidy & fix tests
mcabbott fac481c
two important at-inline-s
mcabbott da566cd
borrow fast path from Zygote 294
mcabbott a7eede2
fix 1.0
mcabbott 276b51b
try again for 1.0
mcabbott 2f34b50
remove an accidentally quadratic algorithm
mcabbott 895d442
...after which, the fast path isn't faster anymore, so delete it.
mcabbott bf2071f
rm some un-thunks
mcabbott e110d74
kwarg types
mcabbott d2d708e
update for 1.0
mcabbott a988dee
fixup
mcabbott 4747dd1
missing end
mcabbott 841b802
v1.11
mcabbott File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are we testing values here?
It would be good to add comments explaining what we are particularly checking for that
test_rrule
will not catchThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test_rrule
doesn't seem to accept integer input, this tests that the rule still does.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add comment to that effect?
Yeah can't test methods that require integers with finite differencing.
Since once you apply a finite difference you get a Float64 instead.
Which means you don't hit the method for integers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment now says "# rule allows integer input, but test_rrule does not"