WIP: use project tangents
#453
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs version bump
oxinabox
reviewed
Jun 23, 2021
| @thunk(Ȳ * B'), | ||
| X̄ -> mul!(X̄, Ȳ, B', true, true) | ||
| @thunk(project(A, Ȳ * B')), | ||
| X̄ -> project(A, mul!(X̄, Ȳ, B', true, true)) |
There was a problem hiding this comment.
I don't think this line is right.
mul has already mutated X bar,
X bar already must have had the right structure so we are fine.
Possibly we needed to project one or both of the inputs to the mul!
|
close in favour of #459 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage of JuliaDiff/ChainRulesCore.jl#380.
This will need a breaking version of FiniteDifferences which perturbs the Diagonal only down its diagonal entries, and not also the zeros.