-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Deprecations. Replace tangent_transforms functionality #180
Conversation
No, probably not. Why are we releasing this right now? |
Yeah, just making sure we don't forget to deprecate things this time. We are planning to release two breaking versions though, right? - One which requires rules to support thunks (0.8) and one which requires the support for ZeroTangent as well (1.0)? |
I was thinking just 1. |
Rand tangent zero-dimensional arrays
looks like we have some issues with it calling |
This is now passing tests. I think we should stop testing thunks in frules. |
Very naive q, but how does it break mutation support? Is it that frules which support mutation can't receive thunks? |
frules for mutating primal functions can't recieve thunks. Shall i remove that from this PR? |
Thanks, makes sense, I was just wondering whether there was anything else to it. I assume mutation support is more important, right? So let's remove the default? I can also do that |
I will do this |
Codecov Report
@@ Coverage Diff @@
## master #180 +/- ##
==========================================
+ Coverage 87.80% 90.94% +3.13%
==========================================
Files 12 11 -1
Lines 328 287 -41
==========================================
- Hits 288 261 -27
+ Misses 40 26 -14
Continue to review full report at Codecov.
|
should we test that we catch bad rules with this? |
Test Summary: | Pass Total | ||
test_scalar: relu at 0.5 | 10 10 | ||
test_scalar: relu at 0.5 | 11 11 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Documenter (fix doctests)] reported by reviewdog 🐶
Test Summary: | Pass Total | |
test_scalar: relu at 0.5 | 10 10 | |
test_scalar: relu at 0.5 | 11 11 |
I approve the commits added (but can't click approve). One thought - should we also keep the empty deprecated.jl file in the tests so that we don't forget to add it? |
Maybe, I think it is not a big deal either way, So I am not going to retrigger CI for that |
Closes #113, closes #164.
Do we also want #179?Make sure thunks are supported in rules in