stringify orig_expr in meta-metatests #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test/meta_testing_tools.jl
Outdated
| # Always calling `string` on it gives gives consistency regardless of version. | ||
| # https://github.com/JuliaLang/julia/pull/37809 | ||
| @test string(fails[1].orig_expr) == "false == true" | ||
| @test string(fails[2].orig_expr) == "true == false" |
There was a problem hiding this comment.
alternatively we could check if orig_expr is a String (or check the Julia version) and Meta.parse it to an Expr?
There was a problem hiding this comment.
then we'd be testing what we want to test (which is that the expression is the one we expect), rather than testing the string representation
There was a problem hiding this comment.
indeed, but it is more complex
There was a problem hiding this comment.
I still lean towards simpler is better
There was a problem hiding this comment.
I've initially done what @nickrobinson251 suggested but I prefer this. In particular the current one which stringifies the expression on the RHS
oxinabox
force-pushed
the
ox/stringifyresults
branch
from
c1dc183
to
88cb0ce
Compare
Closed
mzgubic
approved these changes
Mar 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Julia broke this on current master
JuliaLang/julia#37809 (comment)
I am not particularly in a hurry to see this merged.
I don't love this change, since it is now sensitive to the spacing that julia happens to use for
==