Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support isapprox still #83

Merged
merged 4 commits into from
Dec 15, 2020
Merged

support isapprox still #83

merged 4 commits into from
Dec 15, 2020

Conversation

oxinabox
Copy link
Member

fixed JuliaArrays/BlockDiagonals.jl#49
which was overloading isapprox to support compare natural and structural differentials
which was broken by #57

I want to do more to support those without them overloading isapprox

Copy link
Member

@mzgubic mzgubic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took me a while to figure out how this all fits together, but LGTM

src/check_result.jl Outdated Show resolved Hide resolved
@oxinabox oxinabox merged commit a630c9a into master Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ChainRules rrules_tests fail on Matrix implementation
2 participants