Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rrule test on tuples #89

Merged
merged 1 commit into from
Dec 18, 2020
Merged

Fix rrule test on tuples #89

merged 1 commit into from
Dec 18, 2020

Conversation

oxinabox
Copy link
Member

These tests were failing even after #87

CI being broken seems to have let a bunch of stuff slip through

@oxinabox oxinabox mentioned this pull request Dec 17, 2020
Merged
@oxinabox
Copy link
Member Author

This is what the CI does without this fix
https://github.com/JuliaDiff/ChainRulesTestUtils.jl/runs/1572957783

mzgubic
mzgubic approved these changes Dec 18, 2020
View reviewed changes
Copy link
Member

@mzgubic mzgubic left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's my bad, sorry! I was testing things locally and it looks like I only ran the tests that were failing manually rather than the whole test suite. It's so easy to rely on CI.

Will add this to the backport as well

@oxinabox oxinabox merged commit a3c9808 into master Dec 18, 2020
@oxinabox oxinabox deleted the ox/tuprule branch December 18, 2020 15:09
This was referenced Dec 21, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mzgubic mzgubic mzgubic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oxinabox @mzgubic